dotnet/roslyn

[Tests] These tests seem to check SyntaxToken inside of SyntaxNode

Open

#38,311 opened on Aug 27, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-CompilersBugTesthelp wanted

Description

See https://github.com/dotnet/roslyn/blob/master/src/Compilers/Core/CodeAnalysisTest/CommonSyntaxTests.cs#L181-201 Names node, token and trivia suggest that this test was intended to test VisualBasicExtensions.Kind methods for SyntaxNode, SyntaxToken and SyntaxTrivia of C#. In fact, both first and second invocation test the same method Kind(this SyntaxToken token), because node is actually a SyntaxToken. The same applies to VisualBasicSyntax_CSharpKind test as well.

Contributor guide

Tech stack
csharp
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#Roslyn Syntax API basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue identifies that in CommonSyntaxTests.cs lines 181-201, the variable 'node' is actually a SyntaxToken, so the test incorrectly uses the SyntaxToken overload of Kind. To fix, either rename the variable to 'token' and call the SyntaxToken overload, or change the method call to the SyntaxNode overload by using the correct variable. The same applies to VisualBasicSyntax CSharpKind test. Ensure both tests verify the intended Kind extension methods.
[Tests] These tests seem to check SyntaxToken inside of SyntaxNode · dotnet/roslyn#38311 | Good First Issue