dotnet/roslyn

[Tests] These tests seem to check SyntaxToken inside of SyntaxNode

Open

#38,311 opened on Aug 27, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-CompilersBugTesthelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

See https://github.com/dotnet/roslyn/blob/master/src/Compilers/Core/CodeAnalysisTest/CommonSyntaxTests.cs#L181-201 Names node, token and trivia suggest that this test was intended to test VisualBasicExtensions.Kind methods for SyntaxNode, SyntaxToken and SyntaxTrivia of C#. In fact, both first and second invocation test the same method Kind(this SyntaxToken token), because node is actually a SyntaxToken. The same applies to VisualBasicSyntax_CSharpKind test as well.

Contributor guide

Research direction
Verify the test methods and adjust to test all three types by using separate variables for SyntaxNode, SyntaxToken, and SyntaxTrivia, then call the appropriate Kind overloads.
Tech stack
csharp
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75