dotnet/roslyn

Possible test perf improvement using null stream for pdb sink

Open

#364 opened on Feb 10, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-CompilersFeature RequestTenet-Performancehelp wanted

Description

Should this test code

c.Emit(new MemoryStream(), pdbStream: new MemoryStream()).Diagnostics.Verify(expected);

use Stream.Null instead of a memory stream for performance?

Contributor guide

Tech stack
csharp
Domain
performancetesting
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C# basicsfamiliarity with Stream class
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue proposes replacing `new MemoryStream()` with `Stream.Null` in a test within the Roslyn repository. Identify the exact test file mentioned in the issue (likely in the compiler test suite). Verify that `Stream.Null` is available in the target framework (it is from .NET Core 2.0 onward, and Roslyn likely targets modern .NET). Make the substitution and run the relevant tests to ensure no regression. If accepted, submit a PR changing that single line.
Possible test perf improvement using null stream for pdb sink · dotnet/roslyn#364 | Good First Issue