dotnet/roslyn

Possible test perf improvement using null stream for pdb sink

Open

#364 opened on Feb 10, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-CompilersFeature RequestTenet-Performancehelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Should this test code

c.Emit(new MemoryStream(), pdbStream: new MemoryStream()).Diagnostics.Verify(expected);

use Stream.Null instead of a memory stream for performance?

Contributor guide

Research direction
Replace the MemoryStream in the test with Stream.Null and measure performance difference.
Tech stack
csharp
Domain
backend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90