dotnet/roslyn

Move to new file doesn't honor charset in .editorconfig

Open

#34,200 opened on Mar 17, 2019

View on GitHub
 (0 comments) (2 reactions) (0 assignees)C# (4,257 forks)batch import
Area-IDEBugFeature - Editor Confighelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Version Used: 15.9.9

Steps to Reproduce:

  1. Have an .editorconfig with charset = utf-8
  2. Open an existing file (encoding irrelvant)
  3. Add a type to the file
  4. Apply "Move type to new file" refactoring

Expected Behavior:

The new file is stored in the encoding specified by .editorconfig (in this case UTF8, no BOM).

Actual Behavior:

The new file is stored in UTF8-BOM.

Contributor guide

Research direction
Investigate the 'Move type to new file' refactoring in the Roslyn codebase. Find where the new file is created and how encoding is determined. Check if .editorconfig charset is being read and applied.
Tech stack
csharp
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60