dotnet/roslyn

Extract interface doesn't respect insert_final_newline editorconfig

Open

#33,868 opened on Mar 5, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-IDEBugFeature - Editor ConfigFeature - Extract InterfaceIDE-CodeStylehelp wanted

Description

Version Used: 15.9

Steps to Reproduce:

  1. Run with insert_final_newline=true editorconfig
  2. Run the "Extract Interface" code fix
  3. Look at the generated file

Expected Behavior: The last character(s) are a line break

Actual Behavior: The last character in the file is the closing curly brace of the namespace and git says "No newline at end of file"

Contributor guide

Tech stack
csharp
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic C# knowledgeUnderstanding of editorconfig
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Look into the Extract Interface code fix within the Roslyn codebase, likely in src/Features/ExtractInterface. Investigate how editorconfig settings like insert final newline are applied to generated code. Check other code fixes for consistency, e.g., in CSharpCodeGenerationOptions. The fix should ensure a newline is appended at the end of the generated file.