dotnet/roslyn

VB boolean literals not highlighted as keywords in SymbolDisplay.ToDisplayParts

Open

#30,960 opened on Nov 5, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (4,257 forks)batch import
4 - In ReviewArea-CompilersBughelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Create a C# project and a VB project referencing it. C# file:

public class CS
{
    public const bool Const = true;
}

VB with completion invoked at |.

Module VB
    Sub M()
        CS.|
    End Sub
End Module

image Expected behavior: True is colored as a keyword Actual behavior: it's not

This is because in the result of calling SymbolDisplay.ToDisplayParts on the field, the part with the true keyword has a kind of SymbolDisplayPartKind.NumericLiteral as opposed to SymbolDisplayPartKind.Keyword (so this bug is in the compiler).

Contributor guide

Research direction
Examine the SymbolDisplay.ToDisplayParts implementation to see how boolean literal constants are assigned a NumericLiteral part kind instead of Keyword. Look for the code path that determines the part kind for constant values, and understand why the VB True/False are not treated as keywords.
Tech stack
csharp
Domain
api
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35