dotnet/roslyn

Commas, angle brackets dismiss signature help in strings

Open

#29,669 opened on Sep 4, 2018

View on GitHub
 (3 comments) (1 reaction) (0 assignees)C# (4,257 forks)batch import
Area-IDEBughelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

signaturehelpcommasasretriggers

TL;DR

We believe that all of C#'s trigger characters should probably be considered retrigger characters.

Context

We (@jessetrinity, @sana-ajani, @amcasey and I on the TypeScript team) are trying to tackle the Visual Studio side of https://github.com/Microsoft/TypeScript/issues/1150. We noticed that the most "intuitive" implementation actually results in the undesirable behavior highlighted above. When checking to see what C# does, we saw the same behavior. Rather than diverging, we wanted to consult with Roslyn first to verify whether this is a bug.

Details

Version Used: Latest

Steps to Reproduce:

  1. Write a method Foo accepting a string
  2. Trigger signature help session within a string literal being passed to Foo
  3. Enter a comma character within the string (,)

Expected Behavior:

Signature help remains

Actual Behavior:

Signature help is dismissed

Contributor guide

Research direction
Investigate signature help providers in Roslyn to understand trigger and retrigger character handling, especially for strings. Update the relevant provider to treat commas and angle brackets as retrigger characters when inside strings.
Tech stack
csharp
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65