dotnet/roslyn

Undo should not result in a "rename" tracking session

Open

#26,673 opened on May 7, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-IDEBugFeature - Renamehelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Due to perf issues of bringing up the rename prompt, I've been making use of renaming tracking feature to rename symbols because it's much faster. However, I keep getting into states where it gets "confused" and cannot get it to auto rename to the name I want. Here's an example:

Steps to Reproduce:

  1. Using editor, rename Class -> NewClass
    public class Class
    {
    }

Should look like this: image

  1. Press ESC (or start typing) to dismiss renaming tracking
  2. Press CTRL+Z to undo rename
  3. Rename Class -> NewerClass
  4. Drop down lightbulb

Expected Behavior: To get code fix to rename Class to NewerClass

Actual Behavior: Get a code fix that asks me to rename NewClass to NewerClass

image

Contributor guide

Research direction
Examine how undo affects the rename tracking session. Focus on the code that manages session state and the undo stack. Check the issue's steps to understand the expected behavior.
Tech stack
csharp
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45