dotnet/roslyn

Connect: Entering a # character forces all preprocessor entries to be reindented

Open

#2,487 opened on May 4, 2015

View on GitHub
 (54 comments) (4 reactions) (1 assignee)C# (20,414 stars) (4,257 forks)batch import
Area-IDEBugIDE-Formatterhelp wanted

Description

Ported from TFS WorkItem: 1160552

Repro Steps:

This item was filed by a customer. Please communicate and close the loop with your customer via the customer tab inside TFS.

Problem Description

Hi,

Entering a # character forces all preprocessor entries to be indented again, even when all formatting options have been disabled. It also displaces some "}"s

My setup is: automatical formatting fully disabled , tabs size=4, keep tabs, indenting=none

I'm supplying two images to ease the explanation.

  • Put your code like in image 1. Please note that there's a tabulation before "static void myfunc ()", so #if COND1 is not at the beginning of the line.
  • Put the cursor where the cursor is in the image 1
  • Type #
  • The #if COND1 is automatically indented, and the closing bracket is moved to the right (shown in image 2)

image1: https://dl.dropboxusercontent.com/u/49509038/img/vs2015_ctp6/img1.png

image2: https://dl.dropboxusercontent.com/u/49509038/img/vs2015_ctp6/img2.png

Revisions:

  1. Created By Microsoft Connect (4/21/2015 4:46:12 AM)

------------------------ Customer Information ------------------------ User ID: 10125130 Handle: KakCAT --------------------------- Connect Site Information --------------------------- Site Name: Visual Studio and .NET Framework Site ID: 210 Feedback ID: 1266613 Feedback Form: 6049 ---------------------- Problem Description ----------------------- Hi,

Entering a # character forces all preprocessor entries to be indented again, even when all formatting options have been disabled. It also displaces some "}"s

My setup is: automatical formatting fully disabled , tabs size=4, keep tabs, indenting=none

I'm supplying two images to ease the explanation.

  • Put your code like in image 1. Please note that there's a tabulation before "static void myfunc ()", so #if COND1 is not at the beginning of the line.
  • Put the cursor where the cursor is in the image 1
  • Type #
  • The #if COND1 is automatically indented, and the closing bracket is moved to the right (shown in image 2)

image1: https://dl.dropboxusercontent.com/u/49509038/img/vs2015_ctp6/img1.png image2: https://dl.dropboxusercontent.com/u/49509038/img/vs2015_ctp6/img2.png

  1. Edited By Macy Qu (Shang Hai Wei Chuang Ruan Jian) (4/21/2015 8:11:12 PM)

repro on Win8.1 with VS2015 CTP6

Contributor guide

Tech stack
csharp
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of C# preprocessor directivesFamiliarity with Roslyn syntax and formatting APIs
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the Roslyn formatting engine, specifically the handling of preprocessor directives (#if, #endif). Look at the Formatter class and related syntax walkers. The issue appears when typing '#' triggers re indentation of all preprocessor entries. Check if there is a known fix or linked PRs. Consider the historical context as this is an old issue with many comments.