dotnet/roslyn

Highlight References not symmetric in Tuples

Open

#24,268 opened on Jan 16, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-IDEBugDeveloper Communityhelp wanted

Description

Select "action" here: https://github.com/dotnet/roslyn/blob/6db04109879e42fbe99a3c1e8f1d44175c041e73/src/Workspaces/Core/Portable/CodeFixes/FixAllOccurrences/BatchFixAllProvider.cs#L176

Expected: 4 occurrences (1 def, 3 refs) Actual: 1 occurrence (selected)

Note: FAR correctly shows all 4 Note: Selecting any of the other three occurrences highlights all four occurrences (including the problematic one)

image

image

(Internal) Version 27315.1.d15.6

Contributor guide

Tech stack
csharp
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#Roslyn workspacereference highlighting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Investigate the code in BatchFixAllProvider.cs around line 176 to understand how reference highlighting is computed for tuples. Compare the logic when the first reference is selected vs others. The comment mentions that FAR works correctly, so the issue might be in the highlight logic specifically. Look for any asymmetric handling of tuple positions in the workspace analysis.