dotnet/roslyn

SourceFieldSymbol.HasRuntimeSpecialName should check that containing type is enum

Open

#23,058 opened on Nov 7, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-CompilersBughelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

It feels like we should at least check that the containing type is an enum.

        internal sealed override bool HasRuntimeSpecialName
        {
            get
            {
                return this.Name == WellKnownMemberNames.EnumBackingFieldName;
            }
        }

Relates to https://github.com/dotnet/roslyn/pull/22664#discussion_r149507555

Contributor guide

Research direction
Inspect the SourceFieldSymbol.HasRuntimeSpecialName property and add a validation to check that the containing type is an enum before returning true for EnumBackingFieldName. Then add a corresponding test to verify the fix.
Tech stack
csharp
Domain
compilers
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70