dotnet/roslyn

SourceFieldSymbol.HasRuntimeSpecialName should check that containing type is enum

Open

#23,058 opened on Nov 7, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-CompilersBughelp wanted

Description

It feels like we should at least check that the containing type is an enum.

        internal sealed override bool HasRuntimeSpecialName
        {
            get
            {
                return this.Name == WellKnownMemberNames.EnumBackingFieldName;
            }
        }

Relates to https://github.com/dotnet/roslyn/pull/22664#discussion_r149507555

Contributor guide

Tech stack
csharp
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#basic knowledge of Roslyn symbol API
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue points to `SourceFieldSymbol.HasRuntimeSpecialName` in the Roslyn codebase. The fix involves adding a check that the containing type is an enum before returning true for `EnumBackingFieldName`. The related PR discussion at https://github.com/dotnet/roslyn/pull/22664#discussion r149507555 provides context. To implement, locate the method in the source file and add a condition like `ContainingType?.IsEnumType() == true`.
SourceFieldSymbol.HasRuntimeSpecialName should check that containing type is enum · dotnet/roslyn#23058 | Good First Issue