dotnet/roslyn

DiagnosticLogger.LogHyperlink uses GetHashCode() to persist data

Open

#2,160 opened on Apr 21, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-AnalyzersBughelp wanted

Description

GetHashCode has no guarantee of stability across architectures, runtime implementations, process or AppDomain boundaries, or even build to build (in fact, we used to specifically break GetHashCode in daily CHK builds to prevent internal code from relying on them outside of an AppDomain. Other telemetry is using SHA256 hashes, and LogHyperlink should do the same.

Contributor guide

Tech stack
csharp
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C# basicsunderstanding of hash codes
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Locate the DiagnosticLogger.LogHyperlink method in the Roslyn codebase. Identify existing SHA256 hash usage in other telemetry for consistent approach. Replace GetHashCode() call with SHA256 hash computation, ensuring proper disposal of cryptographic objects.