dotnet/roslyn

In the VB sources, prefer the "Is" operator rather than Object.ReferenceEquals

Open

#2,150 opened on Apr 21, 2015

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-CompilersFeature Requesthelp wanted

Description

We generate slightly better code for the VB Is operator than we do for invocations of Object.ReferenceEquals. It would be nice to replaces uses of the latter with uses of the former.

Contributor guide

Tech stack
None
Domain
backendperformance
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic VB syntaxRoslyn project structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Locate VB source files in the Roslyn repository, likely under src/Compilers/VisualBasic. Search for invocations of Object.ReferenceEquals and replace them with the VB 'Is' operator where semantically equivalent. Ensure the replacement is valid for reference type comparisons only. Since this issue is from 2015, verify that no existing PR or changes have addressed it. Review any comments for additional context.