dotnet/roslyn

In the VB sources, prefer the "Is" operator rather than Object.ReferenceEquals

Open

#2,150 opened on Apr 21, 2015

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-CompilersFeature Requesthelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

We generate slightly better code for the VB Is operator than we do for invocations of Object.ReferenceEquals. It would be nice to replaces uses of the latter with uses of the former.

Contributor guide

Research direction
Find all occurrences of Object.ReferenceEquals in VB source files under the repository, replace them with the 'Is' operator, and run the existing tests to verify correctness.
Tech stack
csharp
Domain
compilers
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
VB.NETGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70