dotnet/roslyn

Extract method over-indents second line of expression

Open

#21,453 opened on Aug 11, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-IDEBugFeature - Extract MethodIDE-Formatterhelp wanted

Description

Version Used: 15.3 Preview 7

:link: Originally revealed by ExtractMethodTests.TestUseExpressionWhenOnSingleLine_AndNotIsOnSingleLine in #21439.

Steps to Reproduce:

  1. Use the following code

    using System;

namespace ConsoleApp5
{
    class Program
    {
        static void Main(string[] args)
        {
            bool b = true;
            Console.WriteLine(b !=
                true ? b = true : b = false);
        }
    }
}

  2. Select b != true

  3. Apply the Extract Method refactoring

Expected Behavior:

using System;

namespace ConsoleApp5
{
    class Program
    {
        static void Main(string[] args)
        {
            bool b = true;
            Console.WriteLine(NewMethod(b) ? b = true : b = false);
        }

        private static bool NewMethod(bool b)
        {
            return b !=
                true;
        }
    }
}

Actual Behavior:

using System;

namespace ConsoleApp5
{
    class Program
    {
        static void Main(string[] args)
        {
            bool b = true;
            Console.WriteLine(NewMethod(b) ? b = true : b = false);
        }

        private static bool NewMethod(bool b)
        {
            return b !=
                            true;
        }
    }
}

Contributor guide

Tech stack
csharp
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#Roslyn refactoring APIssyntax treeunit testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue is a formatting bug in the Extract Method refactoring where the second line of a multi line expression is over indented. The fix likely involves the code that generates the extracted method body, specifically the indentation logic. Look at the linked test `ExtractMethodTests.TestUseExpressionWhenOnSingleLine AndNotIsOnSingleLine` in PR #21439 for context. Search for relevant code in the Roslyn repository, likely in the `Features` or `Workspaces` projects under `ExtractMethod`. Consider adjusting the indentation calculation to align the second line with the first line after extraction.
Extract method over-indents second line of expression · dotnet/roslyn#21453 | Good First Issue