dotnet/roslyn

It looks like LocalRewriter.BuildParamsArray doesn't handle a case of bad or missing int type.

Open

#19,383 opened on May 10, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-CompilersBugLanguage-C#help wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

            var int32Type = methodOrIndexer.ContainingAssembly.GetPrimitiveType(Microsoft.Cci.PrimitiveTypeCode.Int32);

            return new BoundArrayCreation(
                syntax,
                ImmutableArray.Create(
                    MakeLiteral(syntax, ConstantValue.Create(arrayArgs.Length), int32Type)),
                new BoundArrayInitialization(syntax, arrayArgs),
                paramArrayType);

Contributor guide

Research direction
Inspect the LocalRewriter.BuildParamsArray method to understand how it obtains the Int32 type and add handling for when the type is missing.
Tech stack
csharp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70