dotnet/roslyn

It looks like LocalRewriter.BuildParamsArray doesn't handle a case of bad or missing int type.

Open

#19,383 opened on May 10, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-CompilersBugLanguage-C#help wanted

Description

            var int32Type = methodOrIndexer.ContainingAssembly.GetPrimitiveType(Microsoft.Cci.PrimitiveTypeCode.Int32);

            return new BoundArrayCreation(
                syntax,
                ImmutableArray.Create(
                    MakeLiteral(syntax, ConstantValue.Create(arrayArgs.Length), int32Type)),
                new BoundArrayInitialization(syntax, arrayArgs),
                paramArrayType);

Contributor guide

Tech stack
csharp
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
unclear
Prerequisites
C#Roslyn compiler basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
Investigate the LocalRewriter.BuildParamsArray method in the Roslyn source code. Determine the expected behavior for bad or missing int type by reviewing related tests or documentation. Possibly add a null check or default handling for the int32Type variable.