dotnet/roslyn

Don't get offered usings/spell checker etc inside the method body of an abstract method

Open

#19,140 opened on May 1, 2017

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-CompilersBughelp wanted

Description

Was doing refactoring where I wanted to convert an abstract method -> virtual method, I added a body to the abstract method and while I got normal intellisense, I did not offered usings or spelling check code actions, etc until I removed the "abstract".

This feels strange to be me, because other invalid constructs such as unrecognized modifiers don't stop me from getting offered these.

    class Program
    {
        internal abstract void Method()
        {
            String foo; 
        }
    }
  1. CTRL+. on String

Expected: To get offered to add "using System;" Actual: Nothing.

Contributor guide

Tech stack
csharp
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with C# syntaxBasic understanding of Roslyn compiler APIs
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate why abstract method bodies suppress certain code actions (e.g., using directives, spell checker). Look into the completion provider or diagnostic analyzer that handles abstract methods. Check the Roslyn source code for how the compiler context is set for method bodies with abstract modifier. Possibly related to the semantic model or syntax classification. There are 4 comments on the issue; review them for any suggested areas.