dotnet/roslyn

Consider having CopyRefAssembly inherit from Copy

Open

#19,103 opened on Apr 28, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-CompilersBughelp wanted

Description

The new CopyRefAssembly task has logic to determine whether a reference assembly is logically identical by comparing MVIDs of the source and destination files. If the MVIDs do not match, it copies the source assembly to the destination path.

As currently implemented, this copy doesn't have all of the bells and whistles of the Copy task, which supports retries and special-cases a number of scenarios.

CopyRefAssembly could inherit from Copy, override Execute(), do its up-to-date checks, and then after deciding to copy, forward to base.Execute() to get all of the additional magic.

This came up when discussing https://github.com/Microsoft/msbuild/issues/1986 with @jeffkl.

@jcouv -- something to think about. Doesn't block the initial implementation, since no MSBuild change would be required to pick this up.

Contributor guide

Tech stack
csharp
Domain
build systemdeveloper experience
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#MSBuild task implementation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the CopyRefAssembly task implementation and the Copy task in the MSBuild source code. The goal is to refactor CopyRefAssembly to inherit from Copy and forward execution to base.Execute() after custom up to date checks. Review the linked discussion and related issue (Microsoft/msbuild#1986) for context. Examine the existing Execute method and copy logic to ensure compatibility.