dotnet/roslyn

Windows PDB: Improve reusal of imports scopes

Open

#18,004 opened on Mar 20, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-InteractiveInteractive-Debugginghelp wanted

Description

When emitting Windows PDB the compiler doesn't reuse import scopes as much as it could. It currently deduplicates import scopes between two subsequent methods but not across all methods in the compilation. When emitting Portable PDB the scopes are deduplicated across the entire compilation. We can use the same logic to do so for Windows PDBs as well.

Once fixed enable skipped PDB conversion tests refering to this issue.

Contributor guide

Tech stack
csharp
Domain
backendperformance
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#PDB formatRoslyn compiler internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the existing import scope deduplication logic used for Portable PDB emission. The logic likely resides in the PDB writer or emit step. Then apply similar deduplication to Windows PDB emission. Check the skipped PDB conversion tests that reference this issue to enable them after fix.