dotnet/roslyn

Windows PDB: Improve reusal of imports scopes

Open

#18,004 opened on Mar 20, 2017

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-InteractiveInteractive-Debugginghelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

When emitting Windows PDB the compiler doesn't reuse import scopes as much as it could. It currently deduplicates import scopes between two subsequent methods but not across all methods in the compilation. When emitting Portable PDB the scopes are deduplicated across the entire compilation. We can use the same logic to do so for Windows PDBs as well.

Once fixed enable skipped PDB conversion tests refering to this issue.

Contributor guide

Research direction
Examine the existing import scope deduplication logic used for Portable PDBs in the Roslyn compiler and adapt it for Windows PDB emission.
Tech stack
csharp
Domain
compilers
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#compiler internalsPDB
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50