dotnet/roslyn

We should make sure we have adequate test coverage for SemanticModel.GetConversion around DeclarationExpressions

Open

#17,463 opened on Feb 28, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-CompilersFeature - TuplesLanguage-C#Testhelp wanted

Description

For example, what does the API return for the declaration int z in (long x, long y) = (int z, int w);.

This request is coming from @gafter.

Contributor guide

Tech stack
csharp
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C# programmingRoslyn semantic modelUnit testing experience
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate existing tests for SemanticModel.GetConversion in the Roslyn test suite, particularly around DeclarationExpressions. The issue provides an example: a tuple expression with a declaration in deconstruction. Write tests to cover such cases and verify the API behavior. Check comments or linked discussions for additional context; the request comes from gafter.