dotnet/roslyn

Sample unit test code doesnt verify diagnostics at line/column start

Open

#1,641 opened on Mar 27, 2015

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-CompilersBugTesthelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

The issue is in here and here. If the line/column is 0 unit tests will not care if the expected line/column matches that. Also see https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/569.

Contributor guide

Research direction
Inspect the sample test code in DiagnosticVerifier.cs and verify that diagnostics at line/column 0 are correctly validated.
Tech stack
csharp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70