dotnet/roslyn

Sample unit test code doesnt verify diagnostics at line/column start

Open

#1,641 opened on Mar 27, 2015

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-CompilersBugTesthelp wanted

Description

The issue is in here and here. If the line/column is 0 unit tests will not care if the expected line/column matches that. Also see https://github.com/DotNetAnalyzers/StyleCopAnalyzers/pull/569.

Contributor guide

Tech stack
csharp
Domain
testingtooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C# basicsunit testing concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
The issue points to two specific lines in DiagnosticVerifier.cs (lines 193 and 204) where the verification of diagnostics fails when line/column is 0. A similar fix was implemented in StyleCopAnalyzers PR #569, which can serve as a reference. The fix should ensure that when line/column is 0, the expected values are still compared. No linked PR or assignees exist, so work can start independently.