dotnet/roslyn

Can't build Roslyn if Roslyn path or VS path starts from "!"

Open

#16,344 opened on Jan 9, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-Infrastructurehelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

If VS installed into a directory which name start from "!" (for example "c:!\VS\VS2015") or Rosline cloned into same directory (for example "c:!\roslyn") call of Restore.cmd failed with message:

Restore failed with ERRORLEVEL 1

This is because the Restore.cmd starts with: @setlocal enabledelayedexpansion

This settings remove "!" from path.

Contributor guide

Research direction
Find where exclamation marks are used in Restore.cmd and modify to handle them properly.
Tech stack
csharpshell
Domain
build systemdevops
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70