dotnet/roslyn

Microsoft.CodeAnalysis.VisualBasic.SymbolDisplay.ToDisplayString() does not include ByRef for C# ParameterSymbols

Open

#14,683 opened on Oct 22, 2016

View on GitHub
 (1 comment) (1 reaction) (0 assignees)C# (4,257 forks)batch import
Area-CompilersBughelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Microsoft.CodeAnalysis.VisualBasic.SymbolDisplay.ToDisplayString() returns F(Integer) rather than F(ByRef Integer) for:

class C
{
    void F(ref int i) { }
}

See Microsoft.CodeAnalysis.VisualBasic.UnitTests.SymbolDisplayTests.RefReturn.

Contributor guide

Research direction
Look at the ToDisplayString method in VisualBasic/SymbolDisplay and find where ref parameters are not handled for C# symbols. Add a check for RefKind and append 'ByRef ' prefix.
Tech stack
csharp
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Visual Basic syntax
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70