dotnet/roslyn

EE: Comment characters should be ignored in strings and XML literals

Open

#1,453 opened on Mar 20, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-InteractiveBugInteractive-Debugginghelp wanted

Description

Ported from TFS WorkItem: 1120198

  1. Created By Chuck Stoner (2/5/2015 9:01:14 AM)

Contributor guide

Tech stack
csharp
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C# or VB knowledgefamiliarity with debugger expression evaluationunderstanding of Roslyn architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
The bug is in the expression evaluator (EE) for the Watch window, which incorrectly treats comment characters (e.g., '//') as comments even when inside string literals or XML literals. To fix, examine the EE's lexer/parser logic in the Roslyn debugger components, likely in the 'src/ExpressionEvaluator' directory. Determine where comment detection occurs and adjust to skip characters inside strings and XML literals. No prior discussion or linked PRs exist for this issue, so the fix can be implemented from scratch.