dotnet/roslyn

EE: Drop comments started with characters other than ' in root expression

Open

#1,451 opened on Mar 20, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-InteractiveBugInteractive-Debugginghelp wanted

Description

Ported from TFS WorkItem: 1120209

  1. Created By Chuck Stoner (2/5/2015 9:21:11 AM)
  1. Edited By Vladimir Reshetnikov (2/5/2015 7:16:35 PM)

Also consider interaction of comment delimiters in C# and VB with char literals, string literals, interpolated strings, XML literals. Relevant source files are $/Roslyn/Main/Closed/ExpressionEvaluator/VisualBasic/Source/ResultProvider/VisualBasicFormatter.vb and

  1. Edited By Chuck Stoner (2/5/2015 8:37:48 PM)

For string and XML literals, see #1120198.

Contributor guide

Tech stack
csharp
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C# and VB syntaxExpression evaluator basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate comment handling in VisualBasicFormatter.vb and CSharpFormatter.cs, focusing on root expression parsing. Ensure only single quote (') is valid for comments in root expressions and test edge cases with string and XML literals. Refer to issue #1120198 for interaction details.