Return value has incorrect full name · dotnet/roslyn#1448

2015-03-20T23:24:37.000Z

Ported from TFS WorkItem: 1028854 --- Repro Steps: 1. Create new C# Console app with the following code: #pragma warning disable 219 using System; using System.Diagnostics; public class Test { public static void Main() { Test p = new Test(); Debugger.Break(); int i = p.F(p.A(), p.B(), p.C(), p.D()); Test p2 = p.TestValue(); MyEnum e = p.EnumValue(); p.NullValue(); } public int A() { return 1; } public int B() { return 2; } public int C() { return 3; } public int D() { return 4; } public int F(int a, int b, int c, int d) { return a + b + c + d; } public Test TestValue() { return new Test(); } public MyEnum EnumValue() { return MyEnum.VAL1 | MyEnum.VAL2; } public string NullValue() { return null; } public int i = 0; } [Flags] public enum MyEnum { VAL1 = 1, VAL2 = 2, VAL3 = 4 } 2. Start debugging 3. Step over twice 4. Open Autos window 5. Right click top row -> Add to Watch Expected: New watch named "$ReturnValue" is added to the Watch window Actual: New watch named "Test.A returned" is added to the Watch window resulting in a compile error --- Revisions: 1) Created By Patrick Nelson (VS) (9/16/2014 3:50:11 PM) IDkmClrResultProvider.GetResult has a resultFullName parameter that should be used to populate the full name for the root node. Looks like it is currently using resultName for both. --- 2) Edited By Manish Jayaswal (9/17/2014 3:55:49 PM) Updated the repro steps. --- 3) Edited By Manish Jayaswal (10/30/2014 12:07:58 PM) Nice to have. ---

(0 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import

Area-InteractiveBugInteractive-Debugginghelp wanted

Description

Ported from TFS WorkItem: 1028854

Created By Patrick Nelson (VS) (9/16/2014 3:50:11 PM)

IDkmClrResultProvider.GetResult has a resultFullName parameter that should be used to populate the full name for the root node. Looks like it is currently using resultName for both.

Edited By Manish Jayaswal (9/17/2014 3:55:49 PM)

Updated the repro steps.

Edited By Manish Jayaswal (10/30/2014 12:07:58 PM)

Nice to have.

Contributor guide

Tech stack: csharp
Domain: developer experience
Issue type: bug
Difficulty: 3
Estimated time: 1-3 hours
Activity status: stale
Clarity: clear
Prerequisites: Basic understanding of C# debuggerFamiliarity with Roslyn debugging services
Newbie friendliness: 50
Research direction: The bug is in IDkmClrResultProvider.GetResult where resultFullName is not used for the root node. Investigate the implementation, likely in the Microsoft.CodeAnalysis.Debugging namespace. The fix is to assign resultFullName to the root node's full name instead of using resultName.