dotnet/roslyn

Incorrect indentation in LambdaRewriter

Open

#12,709 opened on Jul 24, 2016

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-CompilersBughelp wanted

Description

While looking at LambdaRewriter.cs, I noticed that some lines are incorrectly indented. Specifically, it's the lines fixed by this commit in my fork.

As far as I can tell, the incorrect changes are from this merge from September 2015.

I haven't checked if other files have similar problems.

The Contributing Code page in the repo wiki says that Code Formatter is regularly run on the code in the repo. Presumably, running it would fix the indentation, so I guess it hasn't been run at least since September 2015?

My questions are: Should I just submit a PR with the commit above? Or should someone run the Code Formatter?

Contributor guide

Tech stack
csharp
Domain
tooling
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with C# syntax
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The issue is a simple indentation fix in the file LambdaRewriter.cs located in the CSharp compiler lowering code. The specific changes needed are shown in the linked commit in the issue body. To resolve, apply those indentation corrections or run the Code Formatter tool as mentioned in the repository's contributing guide.