dotnet/roslyn

Missing diagnostic when compiling against bad metadata (where we detect the badness)

Open

#12,653 opened on Jul 21, 2016

View on GitHub
 (2 comments) (0 reactions) (1 assignee)C# (20,414 stars) (4,257 forks)batch import
Area-CompilersBughelp wanted

Description

See https://github.com/dotnet/roslyn/pull/8027#discussion_r50177623 for details.

Contributor guide

Tech stack
csharp
Domain
backenddeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
C# programmingUnderstanding of Roslyn compiler architectureFamiliarity with diagnostic infrastructure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Review the linked PR #8027 and the discussion at the referenced link to understand the specific scenario where a diagnostic is missing when compiling against bad metadata. Investigate the Roslyn source code in the Metadata handling area (likely in src/Compilers/Core/Portable/MetadataReader) to identify where the badness is detected but no diagnostic is emitted. Look for existing similar diagnostics and follow the pattern to add a new one.