dotnet/roslyn

Update diagnostics that refer to Task or Task<T> to include Task-like types

Open

#12,621 opened on Jul 19, 2016

View on GitHub
 (0 comments) (1 reaction) (0 assignees)C# (4,257 forks)batch import
Area-CompilersBugConcept-Diagnostic ClarityFeature - ValueTaskhelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Update diagnostics that refer to Task or Task<T> to include Task-like types.

ERR_BadAsyncReturnExpression
ERR_CantConvAsyncAnonFuncReturns
ERR_TaskRetNoObjectRequired
ERR_BadAsyncReturn
WRN_UnobservedAwaitableExpression_Description

Contributor guide

Research direction
Locate the diagnostic definitions for the listed error codes in the Roslyn codebase. Search for references to 'Task' or 'Task<T>' in those definitions and update them to also include other Task like types such as ValueTask and Task like types from custom libraries. Ensure the changes are consistent across the codebase.
Tech stack
csharp
Domain
compilers
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Gitasync/await
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70