dotnet/roslyn

C#: TypeSymbolExtensions.IsExpressionTree uses some questionable logic

Open

#10,843 opened on Apr 25, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-CompilersBugLanguage-C#help wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

It calls CheckFullName method that doesn't check which containers should be types and which should be namespaces. It also doesn't make sure the whole containership hierarchy is checked.

Contributor guide

Research direction
Examine the CheckFullName method in TypeSymbolExtensions to understand its container checking logic and ensure the entire containership hierarchy is validated.
Tech stack
csharp
Domain
compilers
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60