dotnet/roslyn

C#: TypeSymbolExtensions.IsExpressionTree uses some questionable logic

Open

#10,843 opened on Apr 25, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (20,414 stars) (4,257 forks)batch import
Area-CompilersBugLanguage-C#help wanted

Description

It calls CheckFullName method that doesn't check which containers should be types and which should be namespaces. It also doesn't make sure the whole containership hierarchy is checked.

Contributor guide

Tech stack
csharp
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C# programmingRoslyn compiler basicscontainership hierarchy understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Examine the implementation of TypeSymbolExtensions.IsExpressionTree in the Roslyn codebase. Focus on the CheckFullName method to understand its logic for verifying containership hierarchy. Ensure that the method correctly distinguishes between types and namespaces and checks the entire hierarchy. Look for any unit tests related to this method to verify expected behavior.