dotnet/orleans

SMS events lost in case of serialization failures with no failure indication if FireAndForgetDelivery=true

Open

#1286 opened on Jan 14, 2016

View on GitHub
 (21 comments) (0 reactions) (0 assignees)C# (10,777 stars) (2,123 forks)batch import
bughelp wanted

Description

Reported by @onionhammer.

If FireAndForgetDelivery is set to true, there is no indication to the producer (and to consumer) in case the message payload fails to serialize. The Task returned to producer is successfully resolved before the runtime attempts to send the message.

A potential solution is to resolve the Task returned to producer only after the message is successfully sent or delivered.

Contributor guide

Tech stack
csharp
Domain
backendperformance
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Orleans runtime basicsC# async/awaitSerialization concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the Orleans runtime code related to message delivery and serialization, particularly the FireAndForgetDelivery option. Look into how the Task is currently returned to the producer and where serialization occurs. The proposed solution is to defer resolving the Task until after the message is successfully sent. This may involve changes in the messaging pipeline, such as in the `MessagingRuntime` or `StreamProviderImpl` classes. Additionally, ensure that the fix handles failures appropriately, possibly by throwing or logging the serialization error.