dotnet/orleans

SMS events lost in case of serialization failures with no failure indication if FireAndForgetDelivery=true

Open

#1,286 opened on Jan 14, 2016

View on GitHub
 (21 comments) (0 reactions) (0 assignees)C# (2,123 forks)batch import
bughelp wanted

Repository metrics

Stars
 (10,777 stars)
PR merge metrics
 (Avg merge 2d 2h) (64 merged PRs in 30d)

Description

Reported by @onionhammer.

If FireAndForgetDelivery is set to true, there is no indication to the producer (and to consumer) in case the message payload fails to serialize. The Task returned to producer is successfully resolved before the runtime attempts to send the message.

A potential solution is to resolve the Task returned to producer only after the message is successfully sent or delivered.

Contributor guide

Research direction
Trace the delivery path for SMS messages when FireAndForgetDelivery is true and identify where serialization failures are swallowed. Look at the code that resolves the Task returned to the producer and ensure it waits for the serialization step.
Tech stack
csharp
Domain
backenddistributed systems
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#.NETOrleans
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65