dotnet/msbuild

Add System.Text.Json and System.Memory as builtin implicit references

Open

#9,367 opened on Oct 28, 2023

View on GitHub
 (6 comments) (2 reactions) (0 assignees)C# (5,062 stars) (1,364 forks)batch import
Area: Taskshelp wantedtriaged

Description

To use (even a simplest) JSON serialization in inline tasks (UsingTask), today we are expected to specify two additional references:

  <UsingTask
    TaskName="JsonShenanigans"
    TaskFactory="RoslynCodeTaskFactory"
    AssemblyName="Microsoft.Build.Tasks.Core">
    <Task>
      <Reference Include="System.Text.Json"/>
      <Reference Include="System.Memory"/>
      <Using ...

It would be nice to not require specifying these two references by promoting S.T.J assembly as a first-class citizen of RoslynCodeTaskFactory-based UsingTask.

ps - perhaps the entire set of current Microsoft.NETCore.App / Shared Framework references can be available implicitly in this scope if it does not violate any design principle? Requiring user to only specify <Using Namespace=".." /> to use anything out of SFX.

Contributor guide

Tech stack
csharp
Domain
build system
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#MSBuild basicsRoslynCodeTaskFactory
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Examine the MSBuild source code to locate where implicit references for RoslynCodeTaskFactory are defined (likely in the RoslynCodeTaskFactory class or related configuration). Add System.Text.Json and System.Memory to that list. Review issue comments for any additional guidance or constraints from maintainers.