dotnet/msbuild

WriteOnlyWhenDifferent should check with the same encoding

Open

#8,361 opened on Jan 27, 2023

View on GitHub
 (1 comment) (0 reactions) (1 assignee)C# (1,364 forks)batch import
Area: TasksPartner requestbackloghelp wantedtriaged

Repository metrics

Stars
 (5,062 stars)
PR merge metrics
 (Avg merge 11d 7h) (125 merged PRs in 30d)

Description

The encoding is missing on the check for WriteOnlyWhenDifferent https://github.com/dotnet/msbuild/blob/56087a97257fab6a67d110a7b2c4116f707325ee/src/Tasks/FileIO/WriteLinesToFile.cs#L102 while it's present on the subsequent write: https://github.com/dotnet/msbuild/blob/56087a97257fab6a67d110a7b2c4116f707325ee/src/Tasks/FileIO/WriteLinesToFile.cs#L121

Contributor guide

Research direction
Inspect the code at the referenced lines and add the missing encoding parameter to the condition check.
Tech stack
csharp
Domain
build system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80