dotnet/msbuild

WriteOnlyWhenDifferent should check with the same encoding

Open

#8,361 opened on Jan 27, 2023

View on GitHub
 (1 comment) (0 reactions) (1 assignee)C# (5,062 stars) (1,364 forks)batch import
Area: TasksPartner requestbackloghelp wantedtriaged

Description

The encoding is missing on the check for WriteOnlyWhenDifferent https://github.com/dotnet/msbuild/blob/56087a97257fab6a67d110a7b2c4116f707325ee/src/Tasks/FileIO/WriteLinesToFile.cs#L102 while it's present on the subsequent write: https://github.com/dotnet/msbuild/blob/56087a97257fab6a67d110a7b2c4116f707325ee/src/Tasks/FileIO/WriteLinesToFile.cs#L121

Contributor guide

Tech stack
csharp
Domain
build system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue is located in src/Tasks/FileIO/WriteLinesToFile.cs. The bug is on line 102, where the WriteOnlyWhenDifferent check does not include the encoding parameter, unlike the write on line 121. The fix is to add the encoding parameter to the comparison. The issue has an assignee but no linked PR; check with the assignee or maintainers for current status.