dotnet/msbuild

XmlPoke Should Use DtdProcessing.Prohibit

Open

#5,817 opened on Oct 21, 2020

View on GitHub
 (7 comments) (0 reactions) (2 assignees)C# (1,364 forks)batch import
Good First Issuebugtriaged

Repository metrics

Stars
 (5,062 stars)
PR merge metrics
 (Avg merge 11d 7h) (125 merged PRs in 30d)

Description

See https://github.com/dotnet/msbuild/issues/5810 for a bit of context.

There's an inconsistency with XmlPoke and XslTransformation. The docs on XmlReaderSettings.DtdProcessing state that the default value is Prohibit, which neither XmlPoke or XslTransformation` follow.

Contributor guide

Research direction
Inspect the XmlPoke task implementation to check how it loads XML and ensure DtdProcessing.Prohibit is set. Also review XslTransformation for consistency.
Tech stack
csharp
Domain
backendbuild system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#.NETMSBuild
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75