dotnet/msbuild

Performance Improvement to AssignGlobalRequestId

Open

#5,604 opened on Aug 2, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (1,364 forks)batch import
Area: Performancehelp wantedtriaged

Repository metrics

Stars
 (5,062 stars)
PR merge metrics
 (Avg merge 11d 7h) (125 merged PRs in 30d)

Description

Whilst refactoring I came across this comment, I thought it was worthwhile creating an issue to track it. https://github.com/dotnet/msbuild/blob/15307131458845313df37549b1e25c5076519809/src/Build/BackEnd/Components/Scheduler/Scheduler.cs#L2018-L2022

Relevant code: https://github.com/dotnet/msbuild/blob/15307131458845313df37549b1e25c5076519809/src/Build/BackEnd/Components/Scheduler/Scheduler.cs#L2014-L2058

Contributor guide

Research direction
Investigate the performance of AssignGlobalRequestId in Scheduler.cs. Profile the method and explore optimizations like caching or reducing allocations.
Tech stack
csharp
Domain
build system
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C#MSBuild
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60