dotnet/msbuild

Convert tests to use PlatformSpecific attributes

Open

#331 opened on Nov 4, 2015

View on GitHub
 (0 comments) (0 reactions) (1 assignee)C# (5,062 stars) (1,364 forks)batch import
help wantedtestingtriaged

Description

After adopting xunit.netcore.extensions, we have a nice way to specify that tests are platform-specific, with the [PlatformSpecific] attribute. We should adopt that everywhere and avoid using early-returns like

            if (NativeMethodsShared.IsUnixLike)
            {
                return;
            }

where possible.

Contributor guide

Tech stack
csharp
Domain
testingbuild system
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#xUnitMSBuild testing patterns
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Search for early returns using NativeMethodsShared.IsUnixLike or similar platform checks in test files. Identify patterns like `if (NativeMethodsShared.IsUnixLike) return;` and replace them with `[PlatformSpecific(TestPlatforms.Linux)]` or the appropriate attribute. Refer to existing tests that already use the PlatformSpecific attribute for examples. Ensure you understand the xunit.netcore.extensions library used in the project.