dotnet/msbuild

Re-enable PropertyOverridesContainSemicolon regression test

Open

#259 opened on Oct 6, 2015

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C# (1,364 forks)batch import
CoreCLR-testhelp wantedtriaged

Repository metrics

Stars
 (5,062 stars)
PR merge metrics
 (Avg merge 11d 7h) (125 merged PRs in 30d)

Description

This test does a full C# build internally to guard against regression of an old bug, but that currently fails (on my machine at least) with:

O:\msbuild\bin\Windows_NT\Debug-NetCore\Microsoft.Common.CurrentVersion.targets(1822,5):  error MSB3248: Parameter "AssemblyFiles" has invalid value "C:\Program Files (x86)\Reference Assemblies\Microsoft\Framework\.NETFramework\v4.0\mscorlib.dll". Could not load file or assembly 'System.Reflection.Metadata, Version=1.1.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The located assembly's manifest definition does not match the assembly reference. (Exception from HRESULT: 0x80131040)
Done executing task "ResolveAssemblyReference" -- FAILED.

Which causes the test to fail, because it expected success. This doesn't appear to be the problem that's being tested for, so I'm going to disable the test until we can figure out its root cause.

Contributor guide

Research direction
Investigate the assembly loading error for System.Reflection.Metadata version mismatch. Check the project dependencies and ensure the correct version is referenced. Re enable the test after fixing the root cause.
Tech stack
csharp
Domain
build system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C#MSBuild basicsDependency resolution
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40