dotnet/msbuild

Use current runtime + architecture for GenerateResource on .NET Core

Open

#1,293 opened on Nov 1, 2016

View on GitHub
 (2 comments) (1 reaction) (0 assignees)C# (1,364 forks)batch import
.NET Corebughelp wantedtriaged

Repository metrics

Stars
 (5,062 stars)
PR merge metrics
 (Avg merge 11d 7h) (125 merged PRs in 30d)

Description

See https://github.com/dotnet/sdk/issues/346#issuecomment-257654120.

On .NET Core, MSBuild doesn't support task hosts of different architectures/runtime versions. But the CoreResGen target does some gymnastics to figure out the right architecture/runtime version to use for the GenerateResource task.

On .NET Core we should just use CurrentArchitecture/CurrentRuntime.

Or as @nguerrera suggested, maybe just add the DoesTaskHostExist check for Architecture as well as Runtime.

Contributor guide

Research direction
Investigate the CoreResGen target in Microsoft.Common.CurrentVersion.targets to understand the current architecture detection logic and adapt it for .NET Core by using CurrentArchitecture/CurrentRuntime or adding DoesTaskHostExist check for Architecture.
Tech stack
csharp
Domain
build system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#MSBuild.NET Core
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30