dotnet/msbuild

Test `Regress314573_VeryLongPaths` fails when long paths are not enabled on Windows

Open

#10,952 opened on Nov 7, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (5,062 stars) (1,364 forks)batch import
Priority:3help wantedtriaged

Description

I set up a new machine and see a failure in Regress314573_VeryLongPaths:

Assert.Equal() Failure: Values differ
Expected: 1
Actual:   0
   at Microsoft.Build.UnitTests.ResolveAssemblyReference_Tests.Miscellaneous.Regress314573_VeryLongPaths() in S:\msbuild\src\Tasks.UnitTests\AssemblyDependency\Miscellaneous.cs:line 4919

With this in the log

ERROR MSB3248: Parameter "AssemblyFiles" has invalid value "C:\aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\A.dll". Path: C:\aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa\A.dll exceeds the OS max path limit. The fully qualified file name must be less than 260 characters.

I think the test was trying to detect that that didn't cause a failure when it was written long long ago.

I'm not sure the current behavior is wrong though . . .

Contributor guide

Tech stack
csharp
Domain
build systemtesting
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
unclear
Prerequisites
C#unit testingWindows long path handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the test 'Regress314573 VeryLongPaths' in src/Tasks.UnitTests/AssemblyDependency/Miscellaneous.cs. It fails when long paths are not enabled on Windows. Determine if the test should be conditional on long path support or if the behavior should be changed. Ask maintainers whether the current error on long paths is expected or if the test needs updating.
Test `Regress314573_VeryLongPaths` fails when long paths are not enabled on Windows · dotnet/msbuild#10952 | Good First Issue