dotnet/maui

[Android] Create Date picker dialog on demand instead of inside CreatePlatformView

Open

#8,537 opened on Jul 5, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C# (1,951 forks)batch import
Taskarea-controls-datetimepickerdelighter-scgood first issuelegacy-area-perfperf/generalplatform/android

Repository metrics

Stars
 (23,245 stars)
PR merge metrics
 (Avg merge 47d 9h) (248 merged PRs in 30d)

Description

Currently every DatePicker control creates the dialog inside CreatePlatformView. If that's not a requirement then we should modify the code so the dialog is just created the first time the dialog is requested. If it is required then we should add some comments to the code indicating as such.

Keep in mind the following PR https://github.com/dotnet/maui/pull/5173

Contributor guide

Research direction
Inspect the DatePickerHandler.Android.cs to understand the current dialog creation logic and determine if it can be deferred. Refer to linked PR #5173 for context.
Tech stack
csharp
Domain
mobile
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#.NET MAUIGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70