dotnet/machinelearning

Tests need their own environment implementation

Open

#925 opened on Sep 15, 2018

View on GitHub
 (4 comments) (1 reaction) (0 assignees)C# (9,125 stars) (1,901 forks)batch import
P3good first issuetestup-for-grabs

Description

Right now we use TlcEnvironment (or ConsoleEnvironment) which outputs everything to console. And XUnit don't care about console, and if you want to look on output during test execution you need to do something like this: https://github.com/dotnet/machinelearning/blob/4cb7dd9047b4c456e81ba014c664c27efe217351/test/Microsoft.ML.StaticPipelineTesting/StaticPipeTests.cs#L31

We should have XUnitEnvironment or TestEnvironment and redirect all output to ITestOutputHelper.

Contributor guide

Tech stack
csharp
Domain
testing
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#xUnitML.NET codebase basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue requests creating an XUnitEnvironment or TestEnvironment class that redirects output to ITestOutputHelper instead of using TlcEnvironment or ConsoleEnvironment. The existing code in the linked test file shows how output is currently captured using a console output wrapper. The task involves implementing a new environment class that implements the IEnvironment interface and uses ITestOutputHelper to provide test friendly output. This is a localized change, likely in the test infrastructure, and may require modification of existing tests to use the new environment.