CpuMath Enhancement: Make bound checking of loops in hardware intrinsics more efficient
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 78/100
- Issue type
- Refactor
- Clarity
- Clearly specified
- Activity status
- Active
- Tech stack
- csharp
- Domain
- performance
Research direction
Start by reading the loop-bound checks in src\Microsoft.ML.CpuMath\SseIntrinsics.cs and src\Microsoft.ML.CpuMath\AvxIntrinsics.cs, along with the linked issue and prior pull-request discussion for context. Update the specified checks consistently in both files and verify that the resulting loops preserve their existing bounds while removing the unnecessary instruction.
Written by the indexing model from the issue text.
Description
Style changes needed to solve part of https://github.com/dotnet/machinelearning/issues/823
Details
- In
src\Microsoft.ML.CpuMath\SseIntrinsics.csandsrc\Microsoft.ML.CpuMath\AvxIntrinsics.cs, changingwhile (pDstCurrent + 4 <= pDstEnd)for the loop bound checking intowhile (pDstCurrent <= pDstEnd - 4)to save an instruction (ref: https://github.com/dotnet/machinelearning/pull/668#issuecomment-412121893) - It may probably be a CoreCLR issue
- Dominant language
- C#
- Stars
- 9.4k
- Forks
- 1.9k
- Avg merge
- 2d 1h
- Merged PRs (30d)
- 15
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from dotnet/machinelearning
-
area-Tokenizers green
Difficulty 2/5 1-3 hours Newbie friendliness 85/100
dotnet/machinelearning#7724 · 2 comments · 1 assignee ·
-
area-TimeSeries documentation untriaged
Difficulty 1/5 Under an hour Newbie friendliness 90/100
dotnet/machinelearning#7205 ·
-
area-DataFrame documentation
Difficulty 1/5 1-3 hours Newbie friendliness 68/100
dotnet/machinelearning#6898 ·
-
area-ONNX documentation Priority:3
Difficulty 1/5 Under an hour Newbie friendliness 88/100
dotnet/machinelearning#5894 · 1 comment ·
-
Add a .vsconfig file Openarea-Infrastructure Priority:2
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
dotnet/machinelearning#3260 · 2 comments · 1 reaction ·
All issues in dotnet/machinelearning
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
nightscout/nocturne#1425 ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
-
Documentation
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
cake-build/cake#5024 ·
-
Frontend status/draft TechnicalDebt
Difficulty 2/5 1-2 days Newbie friendliness 75/100
Altinn/altinn-auth#4143 ·