dotnet/eShop

Share model classes between projects

Open

#18 opened on Nov 1, 2023

View on GitHub
 (3 comments) (0 reactions) (1 assignee)C# (10,453 stars) (3,622 forks)batch import
good first issuehelp wanted

Description

From @ReubenBond:

Currently, each project which needs a representation of an Order has its own representation. This makes refactoring complex and it leads to inconsistencies. Instead, we should have one or more shared projects which define the domain model.

If we see a benefit to having a mapped type in some cases (eg, types used in Blazor view models), we should do so, but we should simplify where we can.

Contributor guide

Tech stack
csharp
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#.NETeShop codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the current representation of Order in each project. Identify duplicated model classes across projects like Ordering.API and Ordering.Domain. Plan to move shared models into a common project, e.g., Ordering.Shared. Consider using partial classes or inheritance for any view model specific mappings.