[System.Text.Json] Utf8JsonReader doc incorrectly uses phrases "last processed JSON token", "next JSON token" as synonyms for "current JSON token"

Open Beginner friendly
#8,762 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Documentation
Clarity
Clearly specified
Activity status
Stale
Tech stack
csharp
Domain
documentation

Research direction

Search the API documentation sources for System.Text.Json.Utf8JsonReader and the phrases "last processed JSON token" and "next JSON token". Review the affected member pages, replace references to the current token with consistent wording, and verify that the Get???() and other member documentation no longer describes them as reading the next token.

Written by the indexing model from the issue text.

Description

area-System.Text.Json Pri3

The API documentation pages for various System.Text.Json.Utf8JsonReader members apparently use both the phrases "last processed JSON token" and "next JSON token" to refer to the current JSON token. (https://learn.microsoft.com/en-us/dotnet/api/system.text.json.utf8jsonreader)

For many of the Get???() methods, the documentation incorrectly talks about "Reads the next JSON token value from the source [...]", which is simply false. Only the Read() method reads the next JSON token. (The documentation for the corresponding TryGet???() methods on the other hand correctly state "Tries to parse the current JSON token value [...]".)

And the documentation pages for various other members refer to the "last processed JSON token" instead of referring to the "current JSON token". While the meanings of these two phrases overlap somewhat, they are not perfectly equivalent phrases and therefore using both interchangeably can potentially sow confusion.

I would therefore like to suggest that all documentation pages for System.Text.Json.Utf8JsonReader use only the phrase "current JSON token" when referring to the current JSON token.

Dominant language
C#
Stars
950
Forks
1.7k
Avg merge
3d 5h
Merged PRs (30d)
38

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/dotnet-api-docs

All issues in dotnet/dotnet-api-docs

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.