Follow-up: apply crypto security-warning comments to snippets skipped in #12524 due to build infra

Open
#13,071 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
35/100
Issue type
Documentation
Clarity
Mostly clear
Activity status
Active
Tech stack
csharp, visualbasic

Research direction

Start by reviewing PR #12524 and the Snippets 5000 build failures for the listed C# and Visual Basic files. Check which snippets lack project files or fail assembly and target-framework resolution, then apply the corresponding security-warning comments once the snippets are wired into the pipeline. Done means the affected snippets build successfully and have parity with the C# updates from #12524.

Written by the indexing model from the issue text.

Description

area-System.Security untriaged

[!NOTE]
This issue is AI-generated as follow-up work from PR #12524.

Snippets skipped for security-warning updates due to CI infra

While rebasing PR #12524 (NIST-approved crypto recommendations), the following snippet files could not receive the intended security-warning comments because touching them triggers pre-existing Snippets 5000 build failures unrelated to the change:

Type/assembly resolution failures (CS0234 / CS1069 / CA5372 / signing errors):

  • snippets/csharp/System.Security.Cryptography/AsymmetricAlgorithm/Overview/customcrypto.cs — CustomCrypto.snk file missing (CS7027), duplicate AssemblyVersion attribute
  • snippets/csharp/System.Windows.Forms/DataGridView/CellContentClick/employees.csSystem.Windows.Forms.* not on target framework
  • snippets/csharp/System.Xml.Xsl/XslCompiledTransform/Overview/Xslt_Transform_v2.csXslCompiledTransform.TemporaryFiles (removed in .NET Core)
  • snippets/csharp/VS_Snippets_CFX/s_ue_httpdigestclientcredential/cs/source.csSystem.ServiceModel.* unavailable
  • snippets/csharp/VS_Snippets_CFX/s_ueclientcredentials/cs/program.cs — same
  • snippets/csharp/VS_Snippets_CFX/s_uex509certificatevalidationmode/cs/client.cs — same
  • snippets/csharp/VS_Snippets_CFX/windowsclientcredential/cs/source.cs — same
  • snippets/csharp/VS_Snippets_WebNet/System.Configuration.ProtectedConfigurationProvider/CS/ProtectedConfigurationProviderLib.csSystem.Configuration.ProtectedConfigurationProvider forwarded to unreferenced assembly

"Project missing" (no .csproj / .vbproj alongside the file):

  • snippets/csharp/System.Security.Cryptography/DESCryptoServiceProvider/CreateEncryptor/{file,memory}example.cs
  • All VB counterparts touched by the PR, including:
    • snippets/visualbasic/System.CodeDom/CodeChecksumPragma/Overview/codedirective.vb
    • snippets/visualbasic/System.Security.Cryptography/**/{customcrypto,members,file/memoryexample,source,sample,class1,rfc28981}.vb
    • snippets/visualbasic/VS_Snippets_CFX/s_ueclientcredentials/vb/program.vb
    • snippets/visualbasic/VS_Snippets_Data/*/VB/*.vb
    • snippets/visualbasic/VS_Snippets_WebNet/System.Configuration.ProtectedConfigurationProvider/VB/ProtectedConfigurationProviderLib.vb

Follow-up

Once these snippets have working project files (or are wired up correctly for the Snippets 5000 pipeline), the same NIST-approved / hardcoded-credential / DES-insecurity comments landed in the C# equivalents in #12524 should be applied here for parity. The comment payload is trivial — the blocker is purely CI.

Dominant language
C#
Stars
950
Forks
1.7k
Avg merge
3d 5h
Merged PRs (30d)
38

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/dotnet-api-docs

All issues in dotnet/dotnet-api-docs

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.