[CleanRepo] Orphaned images being mistakenly removed

Open
#445 0 comments 0 reactions 1 assignee View on GitHub

@gewarren is already working on this.

Since Nov 27, 2024.

Assessment

This issue has not been assessed yet.

Description

bug

While using cleanrepo to remove orphaned images on xamarin-docs-pr I discovered the following markdown formats weren't being handled by the tool, and so images were being removed that shouldn't have been:

    ![The Widget tab for an activity
    indicator](progress-indicators-images/activity02.png "The Widget tab for
    an activity indicator")

A high resolution version of the class diagram can be downloaded from [here](class-hierarchy-images/class-diagram-high-resolution.png).

I particularly like the multiple cases of spreading an image link over three lines! Not sure if it's worth the tool handling this. I just fixed the markdown instead. But there were quite a few examples of the second case where an image is actually a download link. In those cases I dropped the images back in place after they were removed. There was also a third case due to writer error on lightbox images (where the images actually rendered fine on learn, despite the markdown being incorrect) - I fixed those.

Dominant language
C#
Stars
27
Forks
43
Avg merge
12h 33m
Merged PRs (30d)
26

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from dotnet/docs-tools

All issues in dotnet/docs-tools

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.