dotnet/aspnetcore

Add support for TypeConverter on propertes/parameters in MVC

Open

#8,857 opened on Mar 27, 2019

View on GitHub
 (9 comments) (4 reactions) (0 assignees)C# (10,653 forks)batch import
affected-fewarea-mvcenhancementfeature-model-bindinghelp wantedseverity-minor

Repository metrics

Stars
 (37,933 stars)
PR merge metrics
 (Avg merge 16d 9h) (258 merged PRs in 30d)

Description

Discussed here originally: https://github.com/aspnet/AspNetCore/issues/8846

This is a really simple way to implement model binding behaviour, and is a totally appropriate thing to do when you have a single field in the request that maps to a complex object.

It would be easy for us to support this because we already have infrastructure that users model binding to call a type converter. We already use type converters defined on types, what this would add would be the ability to use types like List<> and apply the attribute to provide a converter.

Contributor guide

Research direction
Study the existing TypeConverter usage in model binding, locate where type converters are applied to properties, and implement attribute based converter support for MVC parameters and properties.
Tech stack
csharp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C#ASP.NET Core MVCModel Binding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40