dotnet/aspnetcore

Kestrel outputs to console an http url for non-http connection handlers

Open

#8,565 opened on Mar 15, 2019

View on GitHub
 (8 comments) (2 reactions) (1 assignee)C# (10,653 forks)batch import
affected-very-fewarea-networkingenhancementfeature-kestrelhelp wantedseverity-nice-to-have🥌 Bedrock

Repository metrics

Stars
 (37,933 stars)
PR merge metrics
 (Avg merge 16d 9h) (258 merged PRs in 30d)

Description

Describe the bug

When running the WebHost for an application, Kestrel outputs a list of Uri's that it's listening on. When using a custom ConnectionHandler with Kestrel which isn't http, it outputs the uri with an http scheme. You will see a line such as the following:

Now listening on: http://0.0.0.0:8808

To Reproduce

  1. Using Microsoft.AspNetCore.App version 2.2.0
  2. Add a custom ConnectionHandler for Kestrel to use with a unique listening endpoint
  3. Build IWebHost and call Run()
  4. See the previously mentioned console output showing the listening endpoint but with the http scheme

Expected behavior

The ideal thing would be to be able to specify the scheme as part of either the config or a virtual property on ConnectionHandler but that's new api and a feature request. Without new api, output the listening endpoint instead of a Uri. e.g.:

Now listening on: 0.0.0.0:8808

Contributor guide

Research direction
Inspect the Kestrel server code that logs listening addresses and modify it to omit the scheme for non HTTP connection handlers.
Tech stack
csharp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75