dotnet/aspnetcore

Incorrect validation of floating point data

Open

#6,326 opened on Jan 3, 2019

View on GitHub
 (4 comments) (2 reactions) (0 assignees)C# (37,933 stars) (10,653 forks)batch import
affected-fewarea-mvcbugfeature-mvc-razor-viewshelp wantedseverity-minor

Description

Data of floating point types are incorrectly forced to be numbers in general format by client-side validation, without accounting for the possibility of values displayed or inserted in scientific notation. The data-val-number tag is automatically added to, and cannot be trivially removed from the generated HTML. This causes an inconsistency because it suffices to define a default value small or big enough to be displayed in scientific notation (say, 1.0e-5) to receive a validation error at submission even if the entry is perfectly valid.

To Reproduce

Steps to reproduce the behavior:

  1. Create a model with a double data member.
  2. Scaffold a Razor Page with CRUD for the model at point 1.
  3. Try to insert a value in scientific notation in the text box for the variable of double type.
  4. See error

Expected behavior

There are two possibilities: a) values in scientific notation are accepted b) a custom validator should be able to override the data-val-number setting

Contributor guide

Tech stack
csharp
Domain
full stack
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#ASP.NET CoreRazor PagesClient side validation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the source code for the `ValidationAttributeAdapter` or `DataAnnotationsClientModelValidator` to understand how `data val number` is generated. Look for the client side validation script in the repository that parses number values. Check the existing comments for any proposed solutions. Consider adding support for scientific notation in the number validation or providing a way to override the default message.
Incorrect validation of floating point data · dotnet/aspnetcore#6326 | Good First Issue