dotnet/aspnetcore

NavigationManager.Refresh does not make use of optional parameter 'forceReload'

Open

#59,854 opened on Jan 13, 2025

View on GitHub
 (13 comments) (0 reactions) (0 assignees)C# (37,933 stars) (10,653 forks)batch import
area-blazorbughelp wanted

Description

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

Hey!

I wanted to use NavigationManager.Refresh(forceReload: false) on our .NET8 Blazor Server app and noticed that forceReload is not being passed through to NavigateTo, instead the forceReload of NavigateTo defaults to true. You can easily see what I mean in this file in line 178: https://github.com/dotnet/aspnetcore/blob/8d6d208542cbfa4553ae59436cc90d84aac08c6a/src/Components/Components/src/NavigationManager.cs#L178

Expected Behavior

I assume this is not intentional as I cannot come up with a reason why it would be. If the parameter exists one would expect it to be used, right?

Steps To Reproduce

The code is obvious, but NavigationManager.Refresh(forceReload: false) reproduces the issue.

Exceptions (if any)

None

.NET Version

8.0.x

Anything else?

I think the issue speaks for itsself.

Contributor guide

Tech stack
csharp
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
95
Research direction
The bug is in the NavigationManager.Refresh method in the file src/Components/Components/src/NavigationManager.cs at line 178. The method currently calls NavigateTo with a fixed second parameter 'true' instead of passing the 'forceReload' parameter. A first time contributor can fix this by replacing the hardcoded 'true' with the 'forceReload' variable. No additional changes are required.