dotnet/aspnetcore

If one hosting startup class fails to execute, subsequent hosting startup classes defined in the assembly won't be executed.

Open

#5,902 opened on Aug 1, 2017

View on GitHub
 (3 comments) (0 reactions) (0 assignees)C# (37,933 stars) (10,653 forks)batch import
affected-very-fewarea-hostingarea-networkingbughelp wantedseverity-minor

Description

This should probably have a low priority, because I don't know of any real assemblies that define multiple hosting startup classes.

However, the order of attributes returned by Assembly.GetCustomAttributes<HostingStartupAttribute>() can affect whether or not a hosting startup class gets executed or not. It should also be trivial to fix.

Contributor guide

Tech stack
csharp
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C#.NET reflectionASP.NET Core hosting startup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Investigate the order of attributes returned by Assembly.GetCustomAttributes<HostingStartupAttribute>() in the hosting startup execution code. Identify where the enumeration stops on failure and modify to continue to subsequent attributes. Refer to the HostingStartupAttribute and related classes in the repository. Check if there are any existing tests for hosting startup execution.