dotnet/aspnetcore

connection Abort + Dispose crashes process

Open

#57,098 opened on Jul 31, 2024

View on GitHub
 (2 comments) (1 reaction) (0 assignees)C# (37,933 stars) (10,653 forks)batch import
area-networkinghelp wanted

Description

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

I implemented A custom protocol and when I try to close an incoming connection my process crashes

Expected Behavior

Im able to close a connection.

Steps To Reproduce

[TestMethod]
public async Task TestCancelConnection()
{
    var connection = new DefaultConnectionContext();
    connection.Abort();
    await connection.DisposeAsync();

    await Task.Delay(TimeSpan.FromSeconds(1));
}

https://github.com/dotnet/aspnetcore/blob/6dc454f9079ff8d4b268b7e307dd14a05917e903/src/Servers/Connections.Abstractions/src/DefaultConnectionContext.cs#L101

looks like this should have a catch or something that does not blow up if the connection is disposed

Exceptions (if any)

The active test run was aborted. Reason: Test host process crashed : Unhandled exception. System.ObjectDisposedException: The CancellationTokenSource has been disposed. at System.Threading.CancellationTokenSource.Cancel() at System.Threading.ThreadPoolWorkQueue.Dispatch() at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()

.NET Version

8.0.6

Anything else?

No response

Contributor guide

Tech stack
csharp
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic C#async/await
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Look at the file `src/Servers/Connections.Abstractions/src/DefaultConnectionContext.cs` around line 101 where `Abort()` accesses ` cts?.Cancel()`. When `DisposeAsync()` has already disposed the CancellationTokenSource, calling `Cancel()` throws `ObjectDisposedException`. The fix is to add a try catch for `ObjectDisposedException` or check if the CancellationTokenSource is disposed before canceling. Also check if there are similar patterns elsewhere in the file.